Skip to content

[RNMobile] Add 'Insert from URL' option to Video block #41493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 9 commits into from
Jun 9, 2022
Merged

[RNMobile] Add 'Insert from URL' option to Video block #41493

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
13c432f
Add onSelectURL function to mobile Video block edit
derekblank May 27, 2022
4caa013
Add notices store to mobile Video block
derekblank May 27, 2022
7e54122
Display Insert from URL in Video block media options menu
derekblank May 30, 2022
60d5274
Allow native video block to use Embed block for embeddable URLs
derekblank May 30, 2022
d82580b
Update native Video block src onSelectURL attribute
derekblank Jun 1, 2022
5f8becc
Merge branch 'WordPress:trunk' into rnmobile/add-url-option-to-video-…
derekblank Jun 2, 2022
f9e116d
Merge branch 'trunk' into rnmobile/add-url-option-to-video-block
derekblank Jun 9, 2022
4d7166c
Update CHANGELOG
derekblank Jun 9, 2022
f237b67
Merge branch 'rnmobile/add-url-option-to-video-block' of https://gith…
derekblank Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add notices store to mobile Video block
  • Loading branch information
@derekblank
derekblank committed May 27, 2022
commit 4caa0133555faa9a9285b7f8439dbb081fd86644
13 changes: 11 additions & 2 deletions packages/block-library/src/video/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ import { __, sprintf } from '@wordpress/i18n';
import { isURL, getProtocol } from '@wordpress/url';
import { doAction, hasAction } from '@wordpress/hooks';
import { video as SvgIcon, replace } from '@wordpress/icons';
import { withSelect } from '@wordpress/data';
import { withDispatch, withSelect } from '@wordpress/data';
import { store as noticesStore } from '@wordpress/notices';

/**
* Internal dependencies
Expand Down Expand Up @@ -169,7 +170,10 @@ class VideoEdit extends Component {
isFetchingVideo: true,
} );

// TODO: Check if video is valid and set attributes
// TODO: Check if video is valid and set attributes, and also handle errors
// setAttributes( { ... } )
// ...
// createErrorNotice(__('Image file not found.'));
} else {
createErrorNotice( __( 'Invalid URL.' ) );
}
Expand Down Expand Up @@ -394,5 +398,10 @@ export default compose( [
'inserter_menu'
),
} ) ),
withDispatch( ( dispatch ) => {
const { createErrorNotice } = dispatch( noticesStore );

return { createErrorNotice };
} ),
withPreferredColorScheme,
] )( VideoEdit );