Skip to content

Mobile - Skip some of the Drag & Drop E2E on iOS #41529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 2 commits into from
Jun 3, 2022
Merged

Mobile - Skip some of the Drag & Drop E2E on iOS #41529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846e904
Mobile - Skip some of the Drag & Drop E2E on iOS
Jun 3, 2022
1a8101c
Replace if condition to use onlyOnAndroid wrapper instead
Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replace if condition to use onlyOnAndroid wrapper instead
  • Loading branch information
Gerardo committed Jun 3, 2022
commit 1a8101cee49984cc06c4f703173a6b64a8632d21
23 changes: 13 additions & 10 deletions packages/react-native-editor/__device-tests__/gutenberg-editor-drag-and-drop.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ import {
} from './helpers/utils';
import testData from './helpers/test-data';

// Used to skip some tests on iOS
const onlyOnAndroid = isAndroid() ? it : it.skip;

describe( 'Gutenberg Editor Drag & Drop blocks tests', () => {
beforeEach( async () => {
await clearClipboard( editorPage.driver );
Expand Down Expand Up @@ -53,9 +56,9 @@ describe( 'Gutenberg Editor Drag & Drop blocks tests', () => {
await editorPage.removeBlockAtPosition( blockNames.paragraph, 1 );
} );

// skip iOS for now
if ( isAndroid() ) {
it( 'should be able to long-press on a text-based block to paste a text in a focused textinput', async () => {
onlyOnAndroid(
'should be able to long-press on a text-based block to paste a text in a focused textinput',
async () => {
// Add a Paragraph block
await editorPage.addNewBlock( blockNames.paragraph );
const paragraphBlockElement = await editorPage.getTextBlockAtPosition(
Expand Down Expand Up @@ -85,12 +88,12 @@ describe( 'Gutenberg Editor Drag & Drop blocks tests', () => {

// Remove the block
await editorPage.removeBlockAtPosition( blockNames.paragraph );
} );
}
}
);

// skip iOS for now
if ( isAndroid() ) {
it( 'should be able to long-press on a text-based block using the PlainText component to paste a text in a focused textinput', async () => {
onlyOnAndroid(
'should be able to long-press on a text-based block using the PlainText component to paste a text in a focused textinput',
async () => {
// Add a Shortcode block
await editorPage.addNewBlock( blockNames.shortcode );
const shortcodeBlockElement = await editorPage.getShortBlockTextInputAtPosition(
Expand Down Expand Up @@ -118,8 +121,8 @@ describe( 'Gutenberg Editor Drag & Drop blocks tests', () => {

// Remove the block
await editorPage.removeBlockAtPosition( blockNames.shortcode );
} );
}
}
);

it( 'should be able to drag & drop a text-based block when the textinput is not focused', async () => {
// Initialize the editor with two Paragraph blocks
Expand Down