Merged
Conversation
|
Size Change: -2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
torounit
changed the title
torounit
changed the title
ciampo
added
[Type] Code Quality
mirka
approved these changes
Jun 7, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Looks great! I only noticed one minor thing with the default args in the story. And then just add a changelog entry, and we're good to go 👍
Comment on lines
+83
to
+90
| - Type: `string` | `string[]` | ||
| - Required: No | ||
|
|
||
| ### tree | ||
|
|
||
| An array containing the tree objects with the possible nodes the user can select. | ||
|
|
||
| - Type: `String` | ||
| - Type: `Object[]` |
Member
There was a problem hiding this comment.
This is why I can't wait to migrate all our documentation to autogenerated Storybook 😂
Co-authored-by: Lena Morita <lena@jaguchi.com>
dcalhoun
added a commit
that referenced
this pull request
Aug 29, 2022
Add a named export to `SelectControl` so the native module aligns with the web module. The use of a named export was added to code shared between web and native. Because the latter only defined a default export, an error was thrown. - Named export added: #40737 - Named export used: #41536 I am uncertain as to why a named export was added originally. My presumption is that it was recently used so that the import was a local reference, instead of a importing the module's top-level entry file.
dcalhoun
added a commit
that referenced
this pull request
Aug 29, 2022
Add a named export to `SelectControl` so the native module aligns with the web module. The use of a named export was added to code shared between web and native. Because the latter only defined a default export, an error was thrown. - Named export added: #40737 - Named export used: #41536 I am uncertain as to why a named export was added originally. My presumption is that it was recently used so that the import was a local reference, instead of a importing the module's top-level entry file.
dcalhoun
added a commit
that referenced
this pull request
Aug 30, 2022
Add a named export to `SelectControl` so the native module aligns with the web module. The use of a named export was added to code shared between web and native. Because the latter only defined a default export, an error was thrown. - Named export added: #40737 - Named export used: #41536 I am uncertain as to why a named export was added originally. My presumption is that it was recently used so that the import was a local reference, instead of a importing the module's top-level entry file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #35744
What?
Converts the TreeSelect component to TypeScript.
Props changed to match
<SelectControl />.Why?
How?
No runtime changes.
Testing Instructions
npm run storybook:devcheck TreeSelectScreenshots or screencast