Components: refactor FontSizePicker to pass exhaustive-deps#41600
Merged
Components: refactor FontSizePicker to pass exhaustive-deps#41600
FontSizePicker to pass exhaustive-deps#41600Conversation
chad1008
added
[Type] Code Quality
44 tasks
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
chad1008
force-pushed
the
enhance/FontSizePicker-exhuastive.deps
branch
from
dbd2662 to
7ab1e60
Compare
chad1008
changed the title
refactorDraggable to pass exhaustive-depsFontSizePicker to pass exhaustive-deps
chad1008
force-pushed
the
enhance/FontSizePicker-exhuastive.deps
branch
from
7ab1e60 to
a2df833
Compare
ntsekouras
approved these changes
Jun 9, 2022
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks for the PR @chad1008 !
I'm guessing the goal with selectedOption?.slug was to cover both .name and .size with a single dependency
I don't remember exactly, but that was my first thought as well, or something missed(?).. 😄 Either way this PR looks good.
Contributor
Author
|
Awesome, thanks @ntsekouras! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the
FontSizePickercomponent to satisfy theexhaustive-depseslint ruleWhy?
Part of the effort in #41166 to apply
exhuastive-depsto the Components packageHow?
add
selectedOption?.name,selectedOption?.size, andshouldUseSelectControlto theheaderHintuseMemodep array. RemoveselectedOption?.slugwhich isn't a necessary dep of this callback.I'm guessing the goal with
selectedOption?.slugwas to cover both.nameand.sizewith a single dependency, but cc'ing @ntsekouras in case you had something different in mind when this was first introducedTesting Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/font-size-picker