Skip to content

Components: refactor NavigationItem to pass exhaustive-deps #41639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 6 commits into from
Jun 28, 2022
Merged

Components: refactor NavigationItem to pass exhaustive-deps #41639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6048a7d
NavigationItem: add missing deps to `useNavigationTreeItem` `useEffect`
chad1008 Jun 9, 2022
7dc9f3f
NavigationItem: memoize `addItem` with `useCallback`
chad1008 Jun 23, 2022
531f7ec
NavigationItem: memoize `removeItem` with `useCallback`
chad1008 Jun 23, 2022
7b4e697
NavigationItem: add remaining useEffect deps (non-memoized)
chad1008 Jun 23, 2022
b2a0fc7
NavigationItem: update changelog
chad1008 Jun 23, 2022
798f3fe
revert previous changes and ignore exhuastive deps for now
chad1008 Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NavigationItem: memoize removeItem with useCallback
  • Loading branch information
@chad1008
chad1008 committed Jun 27, 2022
commit 531f7ec08f7ed404b2f0ac8e023521ffd1061bc5
2 changes: 1 addition & 1 deletion packages/components/src/navigation/item/use-navigation-tree-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ export const useNavigationTreeItem = ( itemId, props ) => {
return () => {
removeItem( itemId );
};
}, [ activeMenu, search, addItem ] );
}, [ activeMenu, search, addItem, removeItem ] );
};
4 changes: 2 additions & 2 deletions packages/components/src/navigation/use-navigation-tree-nodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ export const useNavigationTreeNodes = () => {
} ) );
}, [] );

const removeNode = ( key ) => {
const removeNode = useCallback( ( key ) => {
return setNodes( ( original ) => {
const { [ key ]: removedNode, ...remainingNodes } = original;
return remainingNodes;
} );
};
}, [] );

return { nodes, getNode, addNode, removeNode };
};