Skip to content

Navigation: add controlled unit test, use modern Testing Library features #41668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 6 commits into from
Jun 15, 2022
Merged

Navigation: add controlled unit test, use modern Testing Library features #41668

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a8be0c
Rewrite tests using user-event and modern testing library asseertions…
ciampo Jun 10, 2022
648a33c
Add controlled test
ciampo Jun 10, 2022
2248a0e
CHANGELOG
ciampo Jun 10, 2022
b848ecb
Fix typo
ciampo Jun 14, 2022
ad82fac
Check for `aria-current` attribute instead of `is-active` classname
ciampo Jun 14, 2022
678afad
Merge branch 'trunk' into feat/navigation-rewrite-logic
ciampo Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'trunk' into feat/navigation-rewrite-logic
  • Loading branch information
@ciampo
ciampo authored Jun 14, 2022
commit 678afad00691184bd6c317bf88ebecd4758adbc1
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
- `CustomGradientBar` updated to satisfy `react/exhuastive-deps` eslint rule ([#41463](https://github.com/WordPress/gutenberg/pull/41463))
- `TreeSelect`: Convert to TypeScript ([#41536](https://github.com/WordPress/gutenberg/pull/41536)).
- `FontSizePicker`: updated to satisfy `react/exhuastive-deps` eslint rule ([#41600](https://github.com/WordPress/gutenberg/pull/41600)).
- `Dropdown`: Make sure cleanup (closing the dropdown) only runs when the menu has actually been opened.
- Enhance the TypeScript migration guidelines ([#41669](https://github.com/WordPress/gutenberg/pull/41669)).

### Experimental

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.