Skip to content

URL: Remove all of Lodash from the package #41687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyxla merged 7 commits into from
Jun 14, 2022
Merged

URL: Remove all of Lodash from the package #41687

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7ede97
url: Introduce remove-accents dependency
tyxla Jun 13, 2022
16afd37
url: Use removeAccents instead of lodash in cleanForSlug
tyxla Jun 13, 2022
3f496c6
url: Remove _.every() from tests
tyxla Jun 13, 2022
8b6e39a
url: Remove unnecessary extra trim
tyxla Jun 13, 2022
f6a8d56
Handle multiple leading or trailing dashes
tyxla Jun 13, 2022
f2f238a
Add a test to cover multiple leading and trailing dashes
tyxla Jun 13, 2022
8832905
Add comments in cleanForSlug for comprehensibility
tyxla Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
url: Remove unnecessary extra trim
  • Loading branch information
@tyxla
tyxla committed Jun 13, 2022
commit 8b6e39a336ddbbd7604d72e33e0d88085080ad65
1 change: 0 additions & 1 deletion packages/url/src/clean-for-slug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ export function cleanForSlug( string ) {
.replace( /[\s\./]+/g, '-' )
.replace( /[^\p{L}\p{N}_-]+/gu, '' )
.toLowerCase()
.trim()
.replace( /(^-)|(-$)/g, '' );
}