Skip to content

Fix newlines in block editor after a user mention #41749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chad1008 wants to merge 3 commits into from
Closed

Fix newlines in block editor after a user mention #41749

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308bab2
Autocomplete: wrap `onChangeOptions` in `useCallback`
chad1008 Jun 15, 2022
760c529
Autocomplete: wrap `announce` in `useCallback`
chad1008 Jun 15, 2022
3a7330d
Autocomplete: update changelog
chad1008 Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Autocomplete: wrap announce in useCallback
  • Loading branch information
@chad1008
chad1008 committed Jun 15, 2022
commit 760c529193eaf6f1151af9a1cd7bdc8718b58943
41 changes: 22 additions & 19 deletions packages/components/src/autocomplete/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,27 +184,30 @@ function useAutocomplete( {
setAutocompleterUI( null );
}

function announce( options ) {
if ( ! debouncedSpeak ) {
return;
}
if ( !! options.length ) {
debouncedSpeak(
sprintf(
/* translators: %d: number of results. */
_n(
'%d result found, use up and down arrow keys to navigate.',
'%d results found, use up and down arrow keys to navigate.',
const announce = useCallback(
( options ) => {
if ( ! debouncedSpeak ) {
return;
}
if ( !! options.length ) {
debouncedSpeak(
sprintf(
/* translators: %d: number of results. */
_n(
'%d result found, use up and down arrow keys to navigate.',
'%d results found, use up and down arrow keys to navigate.',
options.length
),
options.length
),
options.length
),
'assertive'
);
} else {
debouncedSpeak( __( 'No results.' ), 'assertive' );
}
}
'assertive'
);
} else {
debouncedSpeak( __( 'No results.' ), 'assertive' );
}
},
[ debouncedSpeak ]
);

/**
* Load options for an autocompleter.
Expand Down