-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Lodash: Refactor away from _.findKey()
#41806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
295506e
Block Editor: Abstract selection position retrieval
tyxla 4eeb0f4
Add tests for retrieveSelectedAttribute
tyxla 83a4ce7
Refactor away from _.findKey
tyxla f9dad7a
Deprecate _.findKey()
tyxla 03de8ad
Remove autogenerated docs
tyxla 3fe8e9d
Make experimental
tyxla d58dd47
Revert "Make experimental"
tyxla 629d0c8
Keep internal
tyxla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Block Editor: Abstract selection position retrieval
- Loading branch information
commit 295506ecc3c6138c00f386a05ad6d7f2e6ab3238
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export { default as transformStyles } from './transform-styles'; | ||
| export * from './block-variation-transforms'; | ||
| export { default as getPxFromCssUnit } from './parse-css-unit-to-px'; | ||
| export * from './selection'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { findKey } from 'lodash'; | ||
|
|
||
| /** | ||
| * A robust way to retain selection position through various | ||
| * transforms is to insert a special character at the position and | ||
| * then recover it. | ||
| */ | ||
| export const START_OF_SELECTED_AREA = '\u0086'; | ||
|
|
||
| /** | ||
| * Retrieve the block attribute that contains the selection position. | ||
| * | ||
| * @param {Object} blockAttributes Block attributes. | ||
| * @return {string} The name of the block attribute that was previously selected. | ||
| */ | ||
| export function retrieveSelectedAttribute( blockAttributes ) { | ||
| return findKey( | ||
| blockAttributes, | ||
| ( v ) => | ||
| typeof v === 'string' && v.indexOf( START_OF_SELECTED_AREA ) !== -1 | ||
| ); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.