Revert: refactor Autocomplete component to pass exhaustive-deps#41820
Merged
Revert: refactor Autocomplete component to pass exhaustive-deps#41820
Autocomplete component to pass exhaustive-deps#41820Conversation
chad1008
added
[Type] Bug
|
Size Change: -11 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Jun 20, 2022
Contributor
There was a problem hiding this comment.
Code changes LGTM
I just wonder if we should add ESLint ignore comments pointing to this PR to explain why the exhaustive-deps rule is not currently enforced for this component.
I did a quick test and the issues described in #41709 and #41724 can no longer be reproduced — @chad1008 can you also confirm? If that's the case, we can close these 2 issues when this PR gets merged.
Contributor
Author
Good idea. I don't plan on leaving them this way long (I really want to get a better pass at this one, asap!) but smart to leave some context in the meantime!
Confirmed. I tried as hard as I could and couldn't get either to reproduce. I'll close both issues out when this revert merges 👍 |
ciampo
reviewed
Jun 20, 2022
Contributor
|
e2e tests keep failing, maybe a rebase will solve the issue |
chad1008
force-pushed
the
revert/Autocomplete-exhaustive-deps
branch
from
995c0de to
f88d09b
Compare
Contributor
Author
|
Rebased and waiting on tests again 🤞 |
This was referenced Jun 22, 2022
chad1008
added a commit
that referenced
this pull request
Jun 29, 2022
…41820) * Autocomplete: revert exhaustive deps refactor * Autocomplete: update changelog * Autocomplete: temporarily disable exhaustive-deps * remove testing artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts the recent changes in #41382
Why?
This change introduced two new bugs and we're still working on fixes for them:
Reverting the change, adding some tests, and retrying the refactor with these obstacles in mind will be a better UX than keeping the bugs while working on a fix.