Lodash: Refactor away from _.nth()
#41832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Developer Documentation
tyxla
requested review from
aristath,
chad1008,
fabiankaegy,
gziolo,
ntsekouras and
swissspidy
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
fabiankaegy
reviewed
Jun 21, 2022
fabiankaegy
approved these changes
Jun 21, 2022
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
Thanks for the follow-up :) Looks good to me and works as intended :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
nthis used only once in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
nthis straightforward in favor of a simple replacement, based on the index of the element, optionally relative to the length of the array if negative.Testing Instructions
npm run docs:genruns and completes without problems.