Merged
Conversation
tyxla
added
[Type] Performance
tyxla
requested review from
chad1008,
ciampo,
fabiankaegy,
geriux,
gziolo,
hypest,
jorgefilipecosta,
lukewalczak,
mirka,
ntsekouras,
pinarol and
swissspidy
Contributor
|
I see there's already someone from the native mobile (RN) side of things on the reviewers list so, I'll go ahead and remove myself. @tyxla , let me know if you have something specific in mind for me, thanks! |
Member
Author
No problem, sounds good, thanks 👍 |
|
Size Change: -14 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
chad1008
approved these changes
Jun 23, 2022
Contributor
chad1008
left a comment
chad1008
left a comment
There was a problem hiding this comment.
Code changes lgtm and tests are passing. I'll defer to others on the React Native side of things though!
Member
Author
|
Going to ship as the RN part is covered by tests and they're passing. |
Member
|
I wanted to provide a follow up that I tested this on an iPhone SE (iOS 11) and Samsung Galaxy S20 (Android 12). I did not encounter any new issues, but did capture two regressions unrelated to these changes. |
Member
Author
|
Thanks a lot @dcalhoun 🙌 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
values()is used only a few times in the entire codebase. This PR aims to remove that usage. We also remove a couple of simple usages that are used in the affected filesWhy?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
_.values()is straightforward in favor of usingObject.values(). We're also removing a few Lodash usages that are replaced easily with their native counterparts -reduce(),map(),includes(), andsome().Testing Instructions
npm run test-unit packages/edit-post/src/storeQuestions
Since this touches a react native version of a component, should it have a changelog entry @mirka @ciampo?