Check if mac when displaying editor mode toggle shortcut #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Dec 28, 2017
| @@ -1,6 +1,10 @@ | |||
| // eslint-disable-next-line | |||
| const isMac = navigator.platform.toUpperCase().indexOf( 'MAC' ) >= 0; | |||
Contributor
There was a problem hiding this comment.
I guess you could do window.navigator to avoid the eslint issue?
vladanost
deleted the
try/detect-platform-for-editor-mode-toggle-shortcut-display
branch
Member
|
If this file is consumed by the |
Contributor
|
@aduth This is for "display" purpose. To show the actual shortcut in the ellipsis menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #3755
Detecting Mac when displaying editor mode toggle shortcut.
How Has This Been Tested?
Tested on Mac and Linux.
Types of changes
New feature (non-breaking change which adds functionality)