Spacer: Complete TypeScript migration of component#42013
Merged
Conversation
walbo
added
[Feature] UI Components
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jul 1, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Code changes LGTM, Storybook also looks good 🚀
Special thanks for adding details on how each padding and margin prop is supposed to override other less-specific props 🙏
Feel free to merge once the small changelog-related comment is addressed!
walbo
force-pushed
the
refactor/spacer-to-typescript
branch
from
f481753 to
35ffcb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Completes the migration of
Spacercomponent to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Testing Instructions
Spacercontinues to function as expected