Skip to content

Global styles: output :root selector for CSS custom properties #42084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 5 commits into from
Mar 26, 2024
Merged

Global styles: output :root selector for CSS custom properties #42084

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54bc3e7
Replacing usages of body with :root for generated CSS properties, pre…
ramonjd Apr 5, 2023
1660e5e
Update tests after rebase
ramonjd Mar 18, 2024
184ca75
Using :root for CSS custom properties in the site editor and for duot…
ramonjd Mar 18, 2024
50a3a05
Revert mistaken selector swap - reverted to body
ramonjd Mar 18, 2024
8389580
Use const for root selector
ramonjd Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests after rebase
  • Loading branch information
@ramonjd
ramonjd committed Mar 18, 2024
commit 1660e5e2f5a19161aa0aac496f7a992f0bf02048
6 changes: 3 additions & 3 deletions lib/class-wp-theme-json-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2705,8 +2705,8 @@ public function get_root_layout_rules( $selector, $block_metadata ) {
}

/*
* Reset default browser margin on the root body element.
* This is set on the root selector **before** generating the ruleset
* Reset default browser margin on the body element.
* This is set on the body selector **before** generating the ruleset
* from the `theme.json`. This is to ensure that if the `theme.json` declares
* `margin` in its `spacing` declaration for the `body` element then these
* user-generated values take precedence in the CSS cascade.
Expand Down Expand Up @@ -2744,7 +2744,7 @@ public function get_root_layout_rules( $selector, $block_metadata ) {
$css .= ':where(.wp-site-blocks) > :last-child:last-child { margin-block-end: 0; }';

// For backwards compatibility, ensure the legacy block gap CSS variable is still available.
$css .= static::ROOT_CSS_PROPERTIES_SELECTOR . " { --wp--style--block-gap: $block_gap_value; }";
$css .= static::ROOT_CSS_PROPERTIES_SELECTOR . " { --wp--style--block-gap: $block_gap_value; }";
}
$css .= $this->get_layout_styles( $block_metadata );

Expand Down
Loading