Skip to content

Experiment: Style Engine Rules & Store objects #42222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aristath merged 17 commits into from
Jul 15, 2022
Merged

Experiment: Style Engine Rules & Store objects #42222

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4ca1d9b
Add a CSS_Rule object
aristath Jul 7, 2022
df15281
Add a rules store
aristath Jul 7, 2022
da2c433
some inline docs & cleanup on the store
aristath Jul 7, 2022
f6176f7
typos & fixes
aristath Jul 7, 2022
0a6b4ef
remove parent relations for rules
aristath Jul 13, 2022
7c48c5e
escape the selector
aristath Jul 13, 2022
ca30f7e
Allow for multiple named instances of the store
aristath Jul 13, 2022
9de86d7
Use a single declarations object per rule
aristath Jul 14, 2022
59dbf67
Allow chaining methods
aristath Jul 14, 2022
94a141a
Remove esc_html
aristath Jul 14, 2022
be06402
Add a default value for store_name
aristath Jul 14, 2022
d4a2104
use static()
aristath Jul 14, 2022
4104e21
Adding tests
ramonjd Jul 15, 2022
8deefb8
rename get_rule to add_rule
aristath Jul 15, 2022
c3bfa2f
add a remove_rule method
aristath Jul 15, 2022
a5f46e9
minor performance improvement
aristath Jul 15, 2022
f85c3bd
cleanup & added a return doc
aristath Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor performance improvement
  • Loading branch information
@aristath
aristath committed Jul 15, 2022
commit a5f46e94e7c2d317e0cd2c37223738627bf26be9
4 changes: 3 additions & 1 deletion packages/style-engine/class-wp-style-engine-css-rule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ public function set_declarations( $declarations ) {

if ( null === $this->declarations && $is_declarations_object ) {
$this->declarations = $declarations;
} elseif ( null === $this->declarations ) {
return $this;
}
if ( null === $this->declarations ) {
$this->declarations = new WP_Style_Engine_CSS_Declarations( $declarations_array );
}
$this->declarations->add_declarations( $declarations_array );
Expand Down