BorderControl: Update labelling, tooltips and wrap with fieldset and legend #42348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
commented
Jul 12, 2022
| __next36pxDefaultSize={ __next36pxDefaultSize } | ||
| /> | ||
| <UnitControl | ||
| label={ __( 'Border width' ) } |
Contributor
Author
There was a problem hiding this comment.
Should the labels for the inner UnitControl and RangeControl be labelled differently when they are both for controlling the same thing i.e. "Border width"?
Member
There was a problem hiding this comment.
I think it's ok that they are the same, since the distinction is made by the screen reader when it says the role ("stepper" vs. "slider"). Though I'll defer to @afercia if there are better ways.
Contributor
Author
There was a problem hiding this comment.
I'll look to merge these improvements later today but am happy to tweak the labels further in a follow-up if desired.
|
Size Change: +382 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
mirka
reviewed
Jul 13, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Thanks for addressing this so quickly! We need to tweak the padding thing, but otherwise the changes look good to me.
packages/components/src/border-control/border-control/component.tsx
Outdated
Show resolved
Hide resolved
| __next36pxDefaultSize={ __next36pxDefaultSize } | ||
| /> | ||
| <UnitControl | ||
| label={ __( 'Border width' ) } |
Member
There was a problem hiding this comment.
I think it's ok that they are the same, since the distinction is made by the screen reader when it says the role ("stepper" vs. "slider"). Though I'll defer to @afercia if there are better ways.
Contributor
Author
|
Missing changelog incoming via: #42411 |
This was referenced Jul 14, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Updates the
BorderControlcomponent to improve labelling, DOM structure, and tooltips.Note: Improvements to the
BorderBoxControlwill be addressed in a separate PRWhy?
Accessibility is important.
How?
BorderControlwrapping element to afieldsetand its primary label to alegendUnitControlandRangeControlcomponentsgetByRoleandqueryByRolecalls in unit tests to also filter by nameTesting Instructions
npm run test-unit /packages/components/src/border-control/testBorderControlstill functions correctly