Skip to content

[WIP] List View: Try adding partial content for the paragraph block #42387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 3 commits into from
Closed

[WIP] List View: Try adding partial content for the paragraph block #42387

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a72f271
List View: Try adding partial content for the paragraph block
andrewserong Jul 13, 2022
2507d68
Try grouping the two pieces of truncated text within the one parent
andrewserong Jul 29, 2022
5608435
Hack together logic to preserve correct widths
andrewserong Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try grouping the two pieces of truncated text within the one parent
  • Loading branch information
@andrewserong
andrewserong committed Aug 5, 2022
commit 2507d686c0352079d33dff1e39b992439e153fc5
16 changes: 10 additions & 6 deletions packages/block-editor/src/components/list-view/block-select-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,19 @@ function ListViewBlockSelectButton(
spacing={ 1 }
>
<span className="block-editor-list-view-block-select-button__title">
<Truncate ellipsizeMode="auto">{ blockTitle }</Truncate>
</span>
{ !! partialContent && (
<span className="block-editor-list-view-block-select-button__partial-content">
<span className="block-editor-list-view-block-select-button__title__inner-wrapper">
<Truncate ellipsizeMode="auto">
{ partialContent }
{ blockTitle }
</Truncate>
{ !! partialContent && (
<span className="block-editor-list-view-block-select-button__partial-content">
<Truncate ellipsizeMode="auto">
{ partialContent }
</Truncate>
</span>
) }
</span>
) }
</span>
{ blockInformation?.anchor && (
<span className="block-editor-list-view-block-select-button__anchor">
{ blockInformation.anchor }
Expand Down
5 changes: 2 additions & 3 deletions packages/block-editor/src/components/list-view/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,11 @@
min-width: 120px;
}

.block-editor-list-view-block-select-button__title,
.block-editor-list-view-block-select-button__partial-content {
.block-editor-list-view-block-select-button__title {
flex: 1;
position: relative;

.components-truncate {
.block-editor-list-view-block-select-button__title__inner-wrapper {
position: absolute;
width: 100%;
transform: translateY(-50%);
Expand Down