Skip to content

Lodash: Refactor PageAttributesParent away from _.deburr() #42429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 1 commit into from
Jul 15, 2022
Merged

Lodash: Refactor PageAttributesParent away from _.deburr() #42429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"lodash": "^4.17.21",
"memize": "^1.1.0",
"react-autosize-textarea": "^7.1.0",
"rememo": "^4.0.0"
"rememo": "^4.0.0",
"remove-accents": "^0.4.2"
},
"peerDependencies": {
"react": "^17.0.0",
Expand Down
13 changes: 4 additions & 9 deletions packages/editor/src/components/page-attributes/parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
/**
* External dependencies
*/
import {
get,
unescape as unescapeString,
debounce,
find,
deburr,
} from 'lodash';
import { get, unescape as unescapeString, debounce, find } from 'lodash';
import removeAccents from 'remove-accents';

/**
* WordPress dependencies
Expand All @@ -32,8 +27,8 @@ function getTitle( post ) {
}

export const getItemPriority = ( name, searchValue ) => {
const normalizedName = deburr( name ).toLowerCase();
const normalizedSearch = deburr( searchValue ).toLowerCase();
const normalizedName = removeAccents( name || '' ).toLowerCase();
const normalizedSearch = removeAccents( searchValue || '' ).toLowerCase();
if ( normalizedName === normalizedSearch ) {
return 0;
}
Expand Down