Skip to content

Template Parts: Add search to replacement modal #42459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 12 commits into from
Jul 20, 2022
Merged

Template Parts: Add search to replacement modal #42459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
53a3bea
Template Parts: Add search to replacement modal
Mamaduka Jul 15, 2022
f91d9aa
Nitpick
Mamaduka Jul 18, 2022
af6ef39
Make search sticky
Mamaduka Jul 18, 2022
d16c616
Improve search
Mamaduka Jul 18, 2022
c393c6e
Update function name
Mamaduka Jul 18, 2022
d1a78e5
Try absolute position
Mamaduka Jul 18, 2022
c7ebe8c
Search input height
jameskoster Jul 18, 2022
bfcc671
Fix ESLint error
Mamaduka Jul 19, 2022
a44c265
Search input width on small screens
jameskoster Jul 19, 2022
2f1ee80
Position search absolutely on larger screens only
jameskoster Jul 19, 2022
22f8278
Remove absolute positioning
jameskoster Jul 19, 2022
fa3bfca
Use correct z-index
Mamaduka Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use correct z-index
  • Loading branch information
@Mamaduka
Mamaduka committed Jul 19, 2022
commit fa3bfca0cb0652793e1d810646dc7beb8c9c7340
1 change: 1 addition & 0 deletions packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ $z-layers: (
".block-editor-inserter__tabs .components-tab-panel__tab-content": 0, // lower scrolling content
".block-editor-inserter__tabs .components-tab-panel__tabs": 1, // higher sticky element
".block-editor-inserter__search": 1, // higher sticky element
".block-library-template-part__selection-search": 1, // higher sticky element

// These next two share a stacking context
".interface-complementary-area .components-panel" : 0, // lower scrolling content
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/template-part/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

.block-library-template-part__selection-search {
background: $white;
z-index: z-index(".block-editor-template-part__selection-modal");
position: sticky;
top: 0;
padding: $grid-unit-20 0;
z-index: z-index(".block-library-template-part__selection-search");
}