-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Popover: tidy up and improve shifting behavior #42531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c760275
Rename placementToAnimationOrigin internal vars
ciampo 7980324
Rename middleware and placement variables
ciampo 68e285b
Rename forwarded / merged refs
ciampo c8404f9
Add explanatory inline comments
ciampo e7333b2
Rename variables and add comments in useLayoutEffect used to update …
ciampo 6a3ed47
typo
ciampo 3bb40fc
Add default value to __unstableForcePosition prop
ciampo 625036c
Add more deps to reference update useLayoutEffect
ciampo 8abd04a
Custom limiting logic when using iframe
ciampo 91951fa
Renamed leftover placementData variable
ciampo e4fda61
Update comment
ciampo 0781cec
Replace placementToAnimationOrigin logic with hardcoded map
ciampo 73eea97
Add RTL support to transform origin
ciampo 699f472
Take placement into account when limiting the offset
ciampo acc337a
Update placement to animation origin mapping as it used to be
ciampo a6e6609
Move comment into function JSDoc
ciampo 805167d
Move utils to separate function
ciampo 355333b
Add position to placement unit tests
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Rename placementToAnimationOrigin internal vars
- Loading branch information
commit c7602753d38565a8f0498b224bb9e998f30fbf21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.