Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
6ea61f8
WIP
aristath Jul 21, 2022
de75e31
Allow CSS variables in the Declarations class
aristath Jul 21, 2022
d725835
Don't print CSS if styles are empty
aristath Jul 21, 2022
fed8866
more WIP
aristath Jul 21, 2022
c28c576
more fixes
aristath Jul 21, 2022
55788ff
Allow using display when value is not "none"
aristath Jul 22, 2022
677a37d
This comment was removed by mistake
aristath Jul 22, 2022
4f0f411
Fix a failing test - These blocks of styles are identical.
aristath Jul 22, 2022
00e6e0f
Add a get_stores method
aristath Jul 22, 2022
de2a954
reset style-engine stores between tests
aristath Jul 22, 2022
256b795
Add a method to sanitize values
aristath Jul 22, 2022
be57c32
manually confirmed each instance of these tests & their consistency
aristath Jul 22, 2022
b7a862f
fix test: if there are no styles, no CSS gets printed
aristath Jul 22, 2022
9d3a9b8
minor tweak
aristath Jul 22, 2022
b26cb66
another tweak for values sanitizing
aristath Jul 22, 2022
e76d9e8
more value sanitization fixes for quotes
aristath Jul 22, 2022
a081f0e
better testing some style-engine improvements
aristath Jul 22, 2022
e47331d
add space for consistency with the lines below
aristath Jul 22, 2022
2f4cb76
only add whitespace if SCRIPT_DEBUG is enabled
aristath Jul 22, 2022
7fb3f2c
remove whitespace in styles
aristath Jul 22, 2022
22f5321
update some tests
aristath Jul 22, 2022
c43921a
fix usage of trim() functions in the style engine
aristath Jul 22, 2022
6680933
whitespace fixes in tests
aristath Jul 22, 2022
2980533
rename var
aristath Jul 22, 2022
9da7b8f
more tests fixes
aristath Jul 22, 2022
a777954
remove whitespace for consistency
aristath Jul 22, 2022
326aca1
Add add_store() method
aristath Jul 25, 2022
a88316b
cleanup incoming store
aristath Jul 25, 2022
443f1b8
Merge branch 'trunk' into try/global-styles-use-style-engine
aristath Aug 2, 2022
c4b85d7
remove cleanup param
aristath Aug 2, 2022
84483ce
fixing return issue after merge
aristath Aug 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup incoming store
  • Loading branch information
aristath committed Jul 25, 2022
commit a88316bec148398bfe2a0e03f895f98d2f10bd6a
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ public function add_store( WP_Style_Engine_CSS_Rules_Store $store ) {
$incoming_rules = $store->get_all_rules();
foreach ( $incoming_rules as $rule ) {
$this->add_rule( $rule->get_selector() )->add_declarations( $rule->get_declarations() );
$store->remove_rule( $rule->get_selector() );
}
return $this;
}
Expand Down