Skip to content

Use slug instead of id for ref in Navigation block #42809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getdave wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Use slug instead of id for ref in Navigation block #42809

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6bdcb54
Apply changes manually from trunk
getdave Oct 14, 2022
213758b
Add slug attr and remove ref deprecation
getdave Oct 14, 2022
bed1f5c
Use new slug attribute as canonical menu reference in preference to r…
getdave Sep 7, 2022
5b15995
Fix front of site to handle slug as well as ref
getdave Sep 7, 2022
c996274
Check for slug in __unstableLocation handling
getdave Sep 7, 2022
6f42e06
Improve comments around attribute migration effect
getdave Sep 7, 2022
2817c15
Add tests for isNumeric
getdave Sep 7, 2022
3455ffc
Pass slug arg
getdave Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve comments around attribute migration effect
  • Loading branch information
@getdave
getdave committed Oct 14, 2022
commit 6f42e06914698d29452a52582f680ac23c1a5253
5 changes: 3 additions & 2 deletions packages/block-library/src/navigation/edit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,9 @@ function Navigation( {
const isEntityAvailable =
! isNavigationMenuMissing && isNavigationMenuResolved;

// Migrate numerical ID-based ref to
// string slug-based ref.
// Migrate the numerical ID-based ref attribute to the
// string-based slug attribute. This action soft-deprecates
// usage of the ref attribute in favour of the slug attribute.
useEffect( () => {
if ( isEntityAvailable && isNumeric( ref ) ) {
setRef( navigationMenu?.slug );
Expand Down