-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Popover: fix limitShift logic by adding iframe offset correctly (and a custom shift limiter) #42950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
09773f1
Extract placement utilities
ciampo cf71889
Add offset to limitShift functionality to compensate iframe s offset
ciampo 61da3a0
CHANGELOG
ciampo 5f67818
Custom limitShift implementation
ciampo fce608e
Add offset to the iframe via a custom middleware
ciampo d0db89a
Remove unused utilities
ciampo c12aba4
Remove unnecessary offset ref
ciampo 6dc52d7
Update CHANGELOG
ciampo 8d01dbf
Add reference to floating-ui s MIT license
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add reference to floating-ui s MIT license
- Loading branch information
commit 8d01dbf016741f9efa9ebd47757449e9d116ffaf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.