Skip to content

Popover: anchor correctly to parent node when no explicit anchor is passed #42971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 5 commits into from
Aug 9, 2022
Merged

Popover: anchor correctly to parent node when no explicit anchor is passed #42971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e57541f
Popover: use fallback anchor s parent instead of fallback anchor itself
ciampo Aug 4, 2022
925b9dd
Update arrow layout to work better in all scenarios
ciampo Aug 4, 2022
f1d4f69
Anchor "Edit link" popover to its button instead of the whole toolbar
ciampo Aug 4, 2022
8334396
Fix typo
ciampo Aug 9, 2022
0ab2981
CHANGELOG
ciampo Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Popover: use fallback anchor s parent instead of fallback anchor itself
  • Loading branch information
@ciampo
ciampo committed Aug 9, 2022
commit e57541f491329f99535586649f6578e003edbd34
4 changes: 3 additions & 1 deletion packages/components/src/popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,9 @@ const Popover = (
},
};
} else if ( anchorRefFallback.current ) {
resultingReferenceRef = anchorRefFallback.current;
// If not explicit ref if passed via props, fallback to
// anchoring to the popover's parent node.
resultingReferenceRef = anchorRefFallback.current.parentNode;
}

if ( ! resultingReferenceRef ) {
Expand Down