Skip to content

Fix block toolbar offset in site editor when toggling sidebars #43172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 6 commits into from
Aug 15, 2022
Merged

Fix block toolbar offset in site editor when toggling sidebars #43172

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b88fadc
Fix block toolbar offset when using the inserter sidebar in the site …
talldan Aug 12, 2022
9029f33
Remove update - this does not seem to be needed
talldan Aug 12, 2022
a0f491e
Changelog
talldan Aug 12, 2022
df0f5d3
Nitpicky updates to comment
talldan Aug 12, 2022
a3dba0d
Combine the resize effect with the existing scroll layout effect
talldan Aug 15, 2022
1b49b39
Use `frameOffset.current` for ternary logic
talldan Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove update - this does not seem to be needed
  • Loading branch information
@talldan
talldan committed Aug 15, 2022
commit 9029f334d3dfc2f9c7e81a8238b12d6258d8e7f5
9 changes: 1 addition & 8 deletions packages/components/src/popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,8 @@ const Popover = (
return;
}

const { defaultView } = ownerDocument;

defaultView.addEventListener( 'resize', update );
ownerDocument.addEventListener( 'scroll', update );

return () => {
defaultView.removeEventListener( 'resize', update );
ownerDocument.removeEventListener( 'scroll', update );
};
return () => ownerDocument.removeEventListener( 'scroll', update );
}, [ ownerDocument ] );

/** @type {false | string} */
Expand Down