[Docs] Replace useState with edit in useEntityRecord usage examples #43270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Developer Documentation
adamziel
changed the title
gziolo
reviewed
Aug 16, 2022
gziolo
reviewed
Aug 16, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I like the change for the example included as it promotes the API included with useEntityRecord. We need to ensure that useCallback will work correctly when the id changes that I have doubts about.
Co-authored-by: Greg Ziółkowski <[email protected]>
Member
|
Static Analysis failed - the same changes need to be applied to JSDoc comment for |
gziolo
approved these changes
Aug 17, 2022
gziolo
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The usage example added in Add mutations data and helper functions to useEntityRecord proposes storing updates via
useState. However, the new mutation helpers can store them directly in the entity record. This PR updates the example to do just that.cc @gziolo