Lodash: Refactor away from _.upperFirst()
#43306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
aristath,
chad1008,
fabiankaegy,
jorgefilipecosta,
ntsekouras,
sgomes and
swissspidy
|
Size Change: +32 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Aug 17, 2022
ntsekouras
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.upperFirst()usage completely and deprecates the function.With
kebabCase(), this is one of the last remaining case handling functions we need to decouple from Lodash.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
In particular, we replace a few of
upperFirst()Lodash usages in favor of a custom inline function that handles it.We could have used
change-caseas in #42427, however, it would require using a separate dependency (upperCaseFirstis not included in the primarychange-casepackage, it has its own package), so we're making a compromise to inline the function because of its simplicity, in order to not have to add another dependency just for this.Testing Instructions
npx @wordpress/create-block test-block