[Mobile] - Disable FastImage on Android #43322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
geriux
added
the
Mobile App - Automation
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
This was referenced Aug 17, 2022
Contributor
🟢 WordPress-Android TestingTested on a Pixel 3a (physical device) Test case 1 - Image block upload
Steps:
Test case 2 - Gallery block upload
Steps:
Test case 3 - Rotate the device with an Image block
Steps:
|
Contributor
🟢 WordPress-iOS TestingTested on an iPhone 11 (physical device) Test case 1 - Image block upload
Steps:
Test case 2 - Gallery block upload
Steps:
Test case 3 - Rotate the device with an Image block
Steps:
|
mkevins
approved these changes
Aug 17, 2022
Contributor
mkevins
left a comment
mkevins
left a comment
There was a problem hiding this comment.
These changes look good. I tested the scenarios in the description, and everything is working as expected. Thank you for wrangling this Gerardo! Also, thanks for removing the custom logic for handling the orientation change. Hopefully this will no longer be needed when this is re-enabled 👍
Member
Author
|
Thank you for the review and testing @mkevins! |
geriux
removed
the
Mobile App - Automation
geriux
pushed a commit
that referenced
this pull request
Aug 25, 2022
4 tasks
geriux
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Release script: Update react-native-editor version to 1.81.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.81.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Add BlockListCompact (#43431) * Mobile - Introduce BlockListCompact - Lighter version of the default BlockList with simpler functionality for use cases like the List V2 block * Mobile - Update List V2 tests since it's not needed to fire the layout event change with the BlockListCompact component * Mobile - BlockListCompact - Add note of the component props and which block is currently using it * [RNMobile] List block v2: Fix text color inconsistencies with list items (#43244) * List block v2: use default color for preferred color scheme * Use usePreferredColorSchemeStyle hook for List Item style * Remove unneeded font-size value from list item styles * Mobile - Disable FastImage on Android (#43322) * [Mobile] - Fix dynamic React Native version (#43058) * Mobile - Fix dynamic React Native version * Mobile - Adds jvmargs setting * [RNMobile] Use default placeholder text color for native List Item (#43353) * Use default placeholder text color for native List Item * Move list item placeholder hex value to stylesheet * Resolve test failure * Add opacity to list block placeholder color styles * Update List block v2 placholder currentTextColor * Mobile - List Item - Check if currentTextColor is not undefined and moves opacity value into a const * Mobile - List Item - Add optional chaining for style.color Co-authored-by: Gerardo <[email protected]> * Mobile - Update CHANGELOG * Mobile - Update Podfile after resolving conflicts * Mobile - Add mock style for list item Co-authored-by: Derek Blank <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
geriux
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Release script: Update react-native-editor version to 1.81.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.81.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Add BlockListCompact (#43431) * Mobile - Introduce BlockListCompact - Lighter version of the default BlockList with simpler functionality for use cases like the List V2 block * Mobile - Update List V2 tests since it's not needed to fire the layout event change with the BlockListCompact component * Mobile - BlockListCompact - Add note of the component props and which block is currently using it * [RNMobile] List block v2: Fix text color inconsistencies with list items (#43244) * List block v2: use default color for preferred color scheme * Use usePreferredColorSchemeStyle hook for List Item style * Remove unneeded font-size value from list item styles * Mobile - Disable FastImage on Android (#43322) * [Mobile] - Fix dynamic React Native version (#43058) * Mobile - Fix dynamic React Native version * Mobile - Adds jvmargs setting * [RNMobile] Use default placeholder text color for native List Item (#43353) * Use default placeholder text color for native List Item * Move list item placeholder hex value to stylesheet * Resolve test failure * Add opacity to list block placeholder color styles * Update List block v2 placholder currentTextColor * Mobile - List Item - Check if currentTextColor is not undefined and moves opacity value into a const * Mobile - List Item - Add optional chaining for style.color Co-authored-by: Gerardo <[email protected]> * Mobile - Update CHANGELOG * Release script: Update react-native-editor version to 1.81.2 * Release script: Update with changes from 'npm run core preios' * Mobile - List V2 - Prevent error when list is empty (#43861) * Mobile - Update Changelog Co-authored-by: Derek Blank <[email protected]> Co-authored-by: David Calhoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Gutenberg Mobile-> [Mobile] - Disable FastImage on Android wordpress-mobile/gutenberg-mobile#5102WordPress iOS-> [Gutenberg] Test disabling FastImage (Android only) wordpress-mobile/WordPress-iOS#19202WordPress Android-> [Gutenberg] - Test disabling FastImage wordpress-mobile/WordPress-Android#17042What?
There's a current issue on Android #43149 where in some cases the images will disappear with the React Native FastImage library.
Why?
While we investigate the issue and have a fix that covers all cases we should disable it.
How?
By disabling FastImage on Android in all cases and only using the built-in React Native Image component.
Testing Instructions
Test the following cases with the following environments for both iOS and Android:
WP Maintenance Modeplugin)Test case 1 - Image block upload
Test case 2 - Gallery block upload
Test case 3 - Rotate the device with an Image block
Screenshots or screencast
N/A