Skip to content

[RNMobile] Use default placeholder text color for native List Item #43353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 7 commits into from
Aug 25, 2022
Merged

[RNMobile] Use default placeholder text color for native List Item #43353

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ee7a50
Use default placeholder text color for native List Item
derekblank Aug 18, 2022
ea5d86b
Move list item placeholder hex value to stylesheet
derekblank Aug 19, 2022
0c7852d
Resolve test failure
derekblank Aug 19, 2022
cb95eb8
Add opacity to list block placeholder color styles
derekblank Aug 25, 2022
b656a52
Update List block v2 placholder currentTextColor
derekblank Aug 25, 2022
cb68742
Mobile - List Item - Check if currentTextColor is not undefined and m…
Aug 25, 2022
fdb6c4c
Mobile - List Item - Add optional chaining for style.color
Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update List block v2 placholder currentTextColor
  • Loading branch information
@derekblank
derekblank authored and Gerardo committed Aug 25, 2022
commit b656a5240b80436734380aa27c70620a939855db
4 changes: 3 additions & 1 deletion packages/block-library/src/list-item/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,10 @@ export default function ListItemEdit( {
styles[ 'wp-block-list-item__list-item-placeholder--dark' ]
);

const currentTextColor = style?.color || style?.baseColors?.color?.text;

const defaultPlaceholderTextColor = style?.baseColors?.color?.text
? styles.color || style.baseColors.color.text
? currentTextColor
: defaultPlaceholderFromScheme?.color;

// Add hex opacity to default placeholder text color and style object
Expand Down