Fix Post Featured Image border attributes #43426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Bug
jasmussen
approved these changes
Aug 19, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me. I would appreciate another sanity check but it looks right to me.
ntsekouras
force-pushed
the
fix/featured-image-regression
branch
from
aeb2a8d to
5d36c1d
Compare
oandregal
reviewed
Aug 19, 2022
ntsekouras
force-pushed
the
fix/featured-image-regression
branch
from
f5c203e to
1c464db
Compare
ntsekouras
added
the
[Block] Post Featured Image
Contributor
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds checks for the border attributes in Post Featured Image if they exist. Introduced here: #42847
Without the checks there are php notices when a Post Featured Image has no border attributes.