Social Links: Enable alpha on color pickers #43453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiego
added
[Block] Social
aaronrobertshaw
approved these changes
Aug 22, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
This is working well for me.
✅ Icon color alpha channel works
✅ Icon background color alpha channel works
✅ Semi-transparent colors match in editor and frontend.
Contributor
|
I've kicked off the failing e2e again as the error looks unrelated (timeout). Once it passes, this should be right to merge. |
Member
Author
|
Thanks @aaronrobertshaw! |
ramonjd
added a commit
that referenced
this pull request
Aug 23, 2022
Enable alpha for icons and icon background colors added in #43453
ramonjd
added a commit
that referenced
this pull request
Aug 24, 2022
* Adding background color block supports to the social links block. * Adding background color block supports to the social links block. * Revert emptytheme theme.json * Disable contrast checker for the background color Enable alpha for icons and icon background colors added in #43453
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Enable alpha in the color pickers used in the Social Links (Icons) block.
Why?
To create consistency in the color pickers across blocks.
How?
Add
enableAlphato thePanelColorSettingsused in the block.Testing Instructions
Screenshots or screencast
Before:
After:
