Lodash: Remove _.omit() usage from components
#43474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
aristath,
chad1008,
ciampo,
fabiankaegy,
gziolo,
mirka,
ntsekouras,
sgomes and
swissspidy
|
Size Change: -23 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
fabiankaegy
reviewed
Aug 22, 2022
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
I haven't actually loaded the code up in my IDE but doesn't this method create linting warnings since we are creating a bunch of variables that never get used?
fabiankaegy
approved these changes
Aug 22, 2022
tyxla
force-pushed
the
remove/lodash-omit-components
branch
from
3fe1518 to
68acc9a
Compare
Member
Author
|
Thank you for the feedback, both 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.omit()usage from the@wordpress/componentspackage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
_.omit()is easily replaceable by destructuring with...restparameters.Testing Instructions
NavigableContainerNoticeSnackbarUnitControlBottomSheet