Merged
Conversation
mirka
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Aug 22, 2022
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the fix!
I have confirmed that the changes to the width control are reflected correctly in both Canvas and Docs.
Additionally, the component is used as __experimentalBlockAlignmentMatrixControl in the cover block.
But it is internally doesn't accept the prop in the first place, so the block editor should not be affected at all.
mirka
force-pushed
the
alignment-matrix-size
branch
from
a49132e to
9ede621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #43438
What?
Fixes a mistake that passed the public
widthprop to a wrong internal prop, making thewidthprop non-functional.Why?
The
widthprop in AlignmentMatrixControl likely never worked, since this only gives the underlyingdivawidthattribute. The underlying Emotion component (Root) is clearly designed to take asizeprop, so we can pretty confidently say this is the original intent.For what it's worth, there are no specific mentions of this part in the original PR (#21091).
Testing Instructions
npm run storybook:devwidthcontrol.