NavigableContainer: use code instead of keyCode for keyboard events#43606
Merged
NavigableContainer: use code instead of keyCode for keyboard events#43606
Conversation
ciampo
added
[Type] Enhancement
|
Size Change: -10 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/navigable-container-keycode-to-code
branch
2 times, most recently
from
431dda7 to
eae2bb3
Compare
ciampo
commented
Aug 26, 2022
Comment on lines
+102
to
+109
| const targetHasMenuItemRole = | ||
| MENU_ITEM_ROLES.includes( targetRole ); | ||
|
|
||
| // `preventDefault()` on tab to avoid having the browser move the focus | ||
| // after this component has already moved it. | ||
| const isTab = event.code === 'Tab'; | ||
|
|
||
| if ( targetHasMenuItemRole || isTab ) { |
Contributor
Author
There was a problem hiding this comment.
Apart from changing the keyCodes to codes, this is the only other runtime change and it's a bug fix (see code comments and PR description for more details)
tyxla
approved these changes
Aug 29, 2022
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Nice work 👍
Needs a rebase, but other than that, works well and code looks great 🚀
mirka
reviewed
Aug 29, 2022
Comment on lines
+34
to
+35
| <button role="menuitem">Item 1</button> | ||
| <button role="menuitem">Item 2</button> |
Member
There was a problem hiding this comment.
I feel like we should have a more realistic example for this story, in the sense that we likely never want items in a NavigableMenu to all be tabbable. There should only be one tab stop for the entire menu, and the menu items should only be navigable by arrow keys. (I was actually a little confused by this story at first because I was just tabbing through all the items.)
What do you think? I don't have a strong opinion about the actual menuitem implementation (e.g. divs/buttons), but I think the tabIndex handling required for using this component should be part of the example.
Contributor
Author
There was a problem hiding this comment.
Makes sense — currently, "Item 4" is the only non-tabbable item that can be focused with arrow keys.
I will swap some buttons for other non-tabbable items (e.g. divs).
Contributor
Author
There was a problem hiding this comment.
So — it looks like the NavigableMenu only moves focus across focusable elements, while the TabbableContainer element only moves focus across tabbable components:
In this case, it seems that focusable elements = tabbable elements + anything with tabindex = 0. I tried to improve slightly the story in 37be0d4, but honestly I just think that these components are veeery niche and I'm not that sure about their real utility
| @@ -0,0 +1,467 @@ | |||
| /** | |||
Member
There was a problem hiding this comment.
Any reason why the NavigableMenu and TabbableContainer tests are merged into a single file?
Contributor
Author
There was a problem hiding this comment.
Not particularly. I think the main issue is that there's one folder, but actually two different components being exported — and so I didn't know which approach to take.
I'll split the tests into two separate files
Contributor
Author
There was a problem hiding this comment.
Just a thought — did we not recently make some changes to some config where it would only consider index.[ts]s{x} files, either for storybook or test files? Would that matter for this PR?
Member
There was a problem hiding this comment.
Yes, for test/story files, .js files are excluded from type checking:
gutenberg/packages/components/tsconfig.json
Lines 39 to 40 in 9620bae
Contributor
Author
There was a problem hiding this comment.
Just a thought — did we not recently make some changes to some config where it would only consider
index.[ts]s{x}files, either for storybook or test files? Would that matter for this PR?
That's actually what I had in mind — these changes proposed in the update to Storybook V7
Comment on lines
+102
to
+109
| const targetHasMenuItemRole = | ||
| MENU_ITEM_ROLES.includes( targetRole ); | ||
|
|
||
| // `preventDefault()` on tab to avoid having the browser move the focus | ||
| // after this component has already moved it. | ||
| const isTab = event.code === 'Tab'; | ||
|
|
||
| if ( targetHasMenuItemRole || isTab ) { |
Member
There was a problem hiding this comment.
Hmm, so if I understand correctly, this component kind of assumes that all navigable children will have a menuitem* role? 🤔 So in a NavigableMenu, the "prevent scroll containers from scrolling" part will not work if children don't have a menuitem* role. This seems like an important detail that is yet undocumented.
Contributor
Author
There was a problem hiding this comment.
It looks like it — it was a behaviour that existed before this PR, and it was not documented (it looks like NavigableMenu is not used frequently in the codebase, and TabbableContainer is not used at all).
I will add some documentation about it
Contributor
Author
There was a problem hiding this comment.
Done in 9c38277
I explicitly didn't mention the preventDefault behaviour explicitly because it felt like a bit of an implementation detail, which I didn't want to expose in official docs.
… would move the focus by two tabbable elements (instead of one)
ciampo
force-pushed
the
refactor/navigable-container-keycode-to-code
branch
from
b2e1098 to
37be0d4
Compare
ciampo
force-pushed
the
refactor/navigable-container-keycode-to-code
branch
from
79f3d52 to
d1455f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
NavigableContainercomponent to rely oncodeinstead ofkeyCodefor keyboard eventsuser-eventTabbableContainerwhere pressingtaborshift tabwould end up skipping one tabbable element (because both the component and the browser would move focus to the next tabbable)Note that
TabbableContainerdoesn't seem to be used in the repo.Why?
keyCodeis deprecated, and replaced bycodeTesting Instructions
Interact with the Storybook examples, make sure that the components behave as expected.
Inspect the unit tests, make sure that: