Add tsconfig.json to core-data package #43638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
Member
|
I see that TypeScript validation passes on CI. Is there anything left to expose types for the package on npm? |
Contributor
Author
I think so, yes 🎉 This PR gets all the remaining types to behave. |
gziolo
approved these changes
Aug 26, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It’s your call then whether to expose types in this PR or separately 👍
When exposing types we only need to remember to include a breaking change entry in the changelog. We definitely will have different types than those that live now on DefinitelyTyped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds
tsconfig.jsonto the@wordpress/core-data. It's a logical next step after adding all the useful TypeScript types.Testing Instructions
Confirm the checks are green
cc @gziolo @dmsnell @sarayourfriend