Skip to content

Popover: add anchor prop #43691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 36 commits into from
Sep 14, 2022
Merged

Popover: add anchor prop #43691

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
157f8e7
Popover: add new anchor prop, mark other anchor props as deprecated
ciampo Aug 30, 2022
c185f24
Add `anchor` prop to Storybook
ciampo Aug 30, 2022
76fd3f2
Add WP version for deprecated props removal
ciampo Aug 30, 2022
28c7b18
Do not render fallback anchor if there is already a prop-derived anchor
ciampo Aug 30, 2022
16e66d4
Block inbetween inserter: use Popover's new anchor prop (#43693)
ciampo Aug 31, 2022
7b62c02
ListViewDropIndicator: use Popover s new anchor prop (#43694)
ciampo Aug 31, 2022
eef3dc6
Temporarily disable derpecation warnings
ciampo Aug 31, 2022
1866f3f
Block toolbar: use Popover's new anchor prop (#43692)
ciampo Aug 31, 2022
fb6f2ee
Dropdown: use Popover s new anchor prop (#43698)
ciampo Aug 31, 2022
3e59ec1
BlockPopover: prevent error when `selectedElement` is not defined
ciampo Sep 1, 2022
c19495c
Try to avoid infinite loop
ciampo Sep 1, 2022
c342d79
Update PanelRow docs
ciampo Sep 2, 2022
c3a3f61
Edit navigation menu actions: use Popover s new anchor prop
ciampo Sep 2, 2022
03eb730
BorderBoxControl: use Popover's new anchor prop (#43789)
ciampo Sep 5, 2022
33c87f1
Image URL Input: use new anchor prop for Popover (#43784)
ciampo Sep 5, 2022
d1890ed
Edit site Actions: use new anchor prop for Popover (#43810)
ciampo Sep 5, 2022
044dd4a
Buttons block: use new Popover anchor prop (#43785)
ciampo Sep 5, 2022
f9fbae5
Navigation block: use new anchor prop for Popover (#43786)
ciampo Sep 5, 2022
13327ef
Post Date block: use new anchor prop for Popover (#43787)
ciampo Sep 5, 2022
a659e87
Tooltip: refactor using Popover's new anchor prop (#43799)
ciampo Sep 5, 2022
4db67fc
Improve docs around using state instead of refs for the anchor element
ciampo Sep 6, 2022
aadd730
Allow `anchor` to be `null`
ciampo Sep 6, 2022
c787c54
Edit Post: use Popover's new anchor prop (#43808)
ciampo Sep 6, 2022
0ac5e79
Refactor `useAnchorRef` and related components to work with the new P…
ciampo Sep 6, 2022
f9a748a
Re-enable deprecation warnings
ciampo Sep 6, 2022
bc75d2f
Remove fall back to `undefined` from `null`
ciampo Sep 6, 2022
b4973f4
Ensure reactive updates when the popover anchor updates
ciampo Sep 6, 2022
7a7179f
Refactor SocialLinkEdit component to use `anchor` instead of `anchorRef`
ciampo Sep 7, 2022
42a72ac
CHANGELOG
ciampo Sep 7, 2022
8c76d7b
Add new `useAnchor` hook instead of changing existing `useAnchorRef` …
ciampo Sep 7, 2022
d09cbfe
Fix API docs
ciampo Sep 7, 2022
dffc311
Update Popover unit tests
ciampo Sep 7, 2022
dd1b771
Remove unused import
ciampo Sep 7, 2022
24c099a
Use DOMRect in the DomRectWithOwnerDocument type
ciampo Sep 9, 2022
1d11ed2
Improve the wording of deprecation warnings
ciampo Sep 14, 2022
caacb0e
Put more emphasis on storing anchor in local state
ciampo Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dropdown: use Popover s new anchor prop (#43698)
  • Loading branch information
@ciampo
ciampo committed Sep 14, 2022
commit fb6f2ee314d6ed5ff6a7256609a41e7c0c6a0fc7
9 changes: 7 additions & 2 deletions packages/components/src/dropdown/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ export default function Dropdown( props ) {
}

const args = { isOpen, onToggle: toggle, onClose: close };
const hasAnchorRef =
const hasPopoverAnchor =
!! popoverProps?.anchor ||
// Note: `anchorRef`, `getAnchorRect` and `anchorRect` are deprecated and
// be removed from `Popover` from WordPress 6.3
!! popoverProps?.anchorRef ||
!! popoverProps?.getAnchorRect ||
!! popoverProps?.anchorRect;
Expand All @@ -110,7 +113,9 @@ export default function Dropdown( props ) {
// This value is used to ensure that the dropdowns
// align with the editor header by default.
offset={ 13 }
anchorRef={ ! hasAnchorRef ? containerRef : undefined }
anchor={
! hasPopoverAnchor ? containerRef.current : undefined
}
{ ...popoverProps }
className={ classnames(
'components-dropdown__content',
Expand Down