Skip to content

Block toolbar: use Popover's new anchor prop #43692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 2 commits into from
Aug 31, 2022
Merged

Block toolbar: use Popover's new anchor prop #43692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ff84c
Block toolbar: use anchor prop instead of anchorRef.{top,bottom}
ciampo Aug 29, 2022
58650ce
Update packages/block-editor/src/components/block-popover/index.js
ciampo Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/block-editor/src/components/block-popover/index.js 
Co-authored-by: Lena Morita <[email protected]>
  • Loading branch information
@ciampo @mirka
ciampo and mirka authored Aug 31, 2022
commit 58650ce8a73b31832875f6883c2ff81b1b6a16cf
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function BlockPopover(
// Get the biggest rectangle that encompasses completely the currently
// selected element and the last selected element:
// - for top/left coordinates, use the smaller numbers
// - for the bottom/right coordinates, use the larget numbers
// - for the bottom/right coordinates, use the largest numbers
const left = Math.min( selectedBCR.left, lastSelectedBCR.left );
Copy link
Contributor Author

@ciampo ciampo Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is an improved version of the same logic inside the Popover component

const top = Math.min( selectedBCR.top, lastSelectedBCR.top );
const right = Math.max(
Expand Down