Components: Retire LIGHT_GRAY[ 200 ] and DARK_GRAY[ 150 ]#43719
Merged
Conversation
|
Size Change: -51 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 31, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Changes LGTM 🚀
Pinging @jasmussen and @jameskoster to make sure these colors are ok
Contributor
|
This is a nice step forward. But all of these colors are still wrong:
They should be these:
All neutral grays. They look like old colors from before the G2 refresh. That's not to say this PR cannot land: a retired color is a retired color. |
Contributor
|
I believe that @mirka 's change in this PR is going in the direction that you suggest:
This PR is a little step towards it:
I assume that the rest of the |
Contributor
|
Baby steps are great 👍 — just wanted to be clear on the colors in case I hadn't mentioned it before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40392
What?
Replaces the following colors:
LIGHT_GRAY[ 200 ]→GRAY[ 100 ]DARK_GRAY[ 150 ]→GRAY[ 600 ]Affected components:
isShadyprop. Not used anywhere in the repo.)disabledprop.)disabledprop.)Why?
We want to consolidate our grays to the canonical gray scale in
@wordpress/base-styles.How?
Replace with the closest colors in the main GRAY object.
Testing Instructions
npm run storybook:devisShadyprops if you want.Screenshots or screencast