Draggable block tests: click block inserter instead of pressing Enter key #43734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
ciampo
changed the title
ciampo
added
[Type] Automated Testing
This was referenced Aug 31, 2022
tyxla
approved these changes
Aug 31, 2022
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍
They passed for me locally, but also are passing in this PR (as part of the End-to-End Tests / Admin - 2 job)
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "draggable block" e2e tests seem to fail very often — this PR aims at making those tests more resilient.
Previously, the tests assumed that the keyboard focus would always be in the post title, and therefore pressing
Enterwould move the keyboard focus to the first block. This assumption is probably not always true, and can lead to test failures.This PR replaces the pressing of the
Enterkey with a call toclickBlockAppender()Testing instructions
The
Draggable block can drag and drop to the top of a block listandDraggable block can drag and drop to the bottom of a block listtests both pass