Skip to content

Navigation block: use new anchor prop for Popover #43786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 3 commits into from
Sep 5, 2022
Merged

Navigation block: use new anchor prop for Popover #43786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69f1134
Navigation block: use new `anchor` prop for `Popover`
ciampo Sep 1, 2022
5285d84
Use anchor for the Navigation submenu block too
ciampo Sep 1, 2022
b4b91f7
Prevent anchor value from being `null`
ciampo Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/block-library/src/navigation-link/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,8 @@ export default function NavigationLinkEdit( {
<Popover
position="bottom center"
onClose={ () => setIsLinkOpen( false ) }
anchorRef={ listItemRef.current }
// `anchor` should never be `null`
anchor={ listItemRef.current ?? undefined }
__unstableShift
>
<LinkControl
Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/navigation-submenu/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,8 @@ export default function NavigationSubmenuEdit( {
<Popover
position="bottom center"
onClose={ () => setIsLinkOpen( false ) }
anchorRef={ listItemRef.current }
// `anchor` should never be `null`
anchor={ listItemRef.current ?? undefined }
__unstableShift
>
<LinkControl
Expand Down