Skip to content

Add block nesting governance schema updates and docs #43801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alecgeatches wants to merge 17 commits into from
Closed

Add block nesting governance schema updates and docs #43801

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7bc6ee9
Add failing test for valid theme.json schema
alecgeatches Aug 30, 2022
ce7e75a
Fix missing property object types
alecgeatches Aug 30, 2022
66bf0b8
Remove type conflict in fontWeight
alecgeatches Aug 30, 2022
5700764
Refactor fontSizes.fluid into non-union type
alecgeatches Aug 30, 2022
6095a7a
Fix core/archives non-property block having additionalProperties: false
alecgeatches Aug 30, 2022
cd3e2b3
Fix stylesProperties type
alecgeatches Aug 30, 2022
441f338
Fix styleProperties border direction properties
alecgeatches Aug 30, 2022
b49655d
Add required schema, required strict skips to test
alecgeatches Aug 30, 2022
f89f936
Run docs:build for theme.json schema changes
alecgeatches Aug 31, 2022
fbb57ec
Upgrade theme.json schema to draft-07, add nesting
alecgeatches Sep 2, 2022
f60681f
Add an example of a nested block's settings in the theme.json
ingeniumed Sep 2, 2022
ce20a4c
Fix test to directly validate schema against spec
alecgeatches Sep 5, 2022
cea1e32
Fix core/archives block to have object type
alecgeatches Sep 5, 2022
1b850f9
Convert to draft-04, use *Complete properties
alecgeatches Sep 5, 2022
8d223d0
Update schema test to use draft-04 and test compilation
alecgeatches Sep 5, 2022
c6e6bd2
Change blocks to use regular properties by default
alecgeatches Sep 5, 2022
7749202
Update blocks with inner blocks to use nested properties
alecgeatches Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix core/archives non-property block having additionalProperties: false
  • Loading branch information
@alecgeatches
alecgeatches committed Sep 2, 2022
commit 6095a7ab7210ae9ebb3f119283c8c0a1d6886d58
3 changes: 1 addition & 2 deletions schemas/json/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,7 @@
"type": "object",
"properties": {
"core/archives": {
"description": "Archive block. Display a monthly archive of your posts. This block has no block-level settings",
"additionalProperties": false
Copy link
Contributor

@ajlende ajlende Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The archives block does not have any block-level settings, so we should probably update this to add "type": "object" rather than removing "additionalProperties": false

Copy link
Contributor Author

@alecgeatches alecgeatches Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that makes sense to me!

"description": "Archive block. Display a monthly archive of your posts. This block has no block-level settings"
},
"core/audio": {
"$ref": "#/definitions/settingsPropertiesComplete"
Expand Down