Skip to content

Edit navigation: use Popover's new anchor prop #43804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 1 commit into from
Sep 2, 2022
Merged

Edit navigation: use Popover's new anchor prop #43804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/edit-navigation/src/components/header/menu-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
__experimentalText as Text,
} from '@wordpress/components';
import { chevronDown } from '@wordpress/icons';
import { useRef } from '@wordpress/element';
import { useCallback, useState } from '@wordpress/element';
import { decodeEntities } from '@wordpress/html-entities';

/**
Expand All @@ -19,11 +19,15 @@ import { useMenuEntityProp, useSelectedMenuId } from '../../hooks';
export default function MenuActions( { menus, isLoading } ) {
const [ selectedMenuId, setSelectedMenuId ] = useSelectedMenuId();
const [ menuName ] = useMenuEntityProp( 'name', selectedMenuId );
const [ popoverAnchor, setPopoverAnchor ] = useState();

// The title ref is passed to the popover as the anchorRef so that the
// dropdown is centered over the whole title area rather than just one
// part of it.
const titleRef = useRef();
const titleCallbackRef = useCallback( ( node ) => {
// The popover `anchor` prop can not be `null`.
setPopoverAnchor( node ?? undefined );
}, [] );

if ( isLoading ) {
return (
Expand All @@ -36,7 +40,7 @@ export default function MenuActions( { menus, isLoading } ) {
return (
<div className="edit-navigation-menu-actions">
<div
ref={ titleRef }
ref={ titleCallbackRef }
className="edit-navigation-menu-actions__subtitle-wrapper"
>
<Text
Expand All @@ -63,7 +67,7 @@ export default function MenuActions( { menus, isLoading } ) {
className:
'edit-navigation-menu-actions__switcher-dropdown',
position: 'bottom center',
anchorRef: titleRef.current,
anchor: popoverAnchor,
} }
>
{ ( { onClose } ) => (
Expand Down