Skip to content

Style engine: pre-core migration documentation and house keeping #43840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 29 commits into from
Sep 14, 2022
Merged

Style engine: pre-core migration documentation and house keeping #43840

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
aec32e6
Initial commit. Adding further documentation, cleaning up changelog r…
ramonjd Sep 5, 2022
324c7fb
Typos, formatting
ramonjd Sep 5, 2022
66859c1
Typos, formatting
ramonjd Sep 5, 2022
fda9bd9
Sorting out change log and formatting
ramonjd Sep 5, 2022
aad9a7a
Remove enqueue option. It does nothing.
ramonjd Sep 5, 2022
627dda9
Update packages/style-engine/docs/using-the-style-engine-with-block-s…
ramonjd Sep 5, 2022
960e7a9
Update README.md
ramonjd Sep 5, 2022
29a9369
Updating manifest.json to include new style engine docs
ramonjd Sep 6, 2022
47ab494
Adding type annotation
ramonjd Sep 6, 2022
fb680d7
Updating CHANGELOG.md
ramonjd Sep 6, 2022
a0149a5
Updated version to prerelease
ramonjd Sep 6, 2022
2279755
Rebase after #43886
ramonjd Sep 6, 2022
d1939e4
Updating change logs and emphasizing that new global JS methods are a…
ramonjd Sep 7, 2022
1084864
Checking for functions and classes in tests so that Gutenberg tests d…
ramonjd Sep 7, 2022
2d9b645
Formatting PHP doc comments and params that describe associative arrays
ramonjd Sep 8, 2022
3d5e463
Formatting
ramonjd Sep 8, 2022
09843d4
Combining tests for get_declarations_string
ramonjd Sep 8, 2022
7cc64a2
Adding message parameter to assertions where more than one assertion …
ramonjd Sep 8, 2022
53e4edb
Updating PHP docs
ramonjd Sep 8, 2022
5af5d0a
Text domain added to __()
ramonjd Sep 8, 2022
7991cf1
Refactoring sanitization tests for CSS declarations
ramonjd Sep 8, 2022
469b90f
Formatting styleEngine tests
ramonjd Sep 8, 2022
edf81cb
My blod is typo
ramonjd Sep 8, 2022
6f7ef65
Active voice rather than imperative
ramonjd Sep 8, 2022
fb8edd7
Remove Gutenberg suffix
ramonjd Sep 8, 2022
9ac232c
Adding message to script loader block support enqueuing expectations
ramonjd Sep 9, 2022
ccf6773
Grammar, formatting, removing class_exists checks
ramonjd Sep 9, 2022
afc7d9e
Ignore unused variable. This is a common test pattern in Core.
ramonjd Sep 9, 2022
19b6885
Remove unusued var in tests
ramonjd Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unusued var in tests
  • Loading branch information
@ramonjd
ramonjd committed Sep 13, 2022
commit 19b68854114c06a43b46e46a97203af3d4c8fa00
2 changes: 0 additions & 2 deletions phpunit/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ public function clean_up_global_scope() {
* Tests that stored CSS is enqueued.
*/
public function test_enqueue_stored_styles() {
global $wp_styles;

$core_styles_to_enqueue = array(
array(
'selector' => '.saruman',
Expand Down