Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a64ecd8
Release script: Update react-native-editor version to 1.81.0
derekblank Aug 4, 2022
29d06a6
Release script: Update with changes from 'npm run core preios'
derekblank Aug 4, 2022
4d1ca7e
Release script: Update react-native-editor version to 1.81.1
dcalhoun Aug 24, 2022
78fc8f4
Release script: Update with changes from 'npm run core preios'
dcalhoun Aug 24, 2022
9edbebe
[Mobile] - Add BlockListCompact (#43431)
Aug 25, 2022
201e83a
[RNMobile] List block v2: Fix text color inconsistencies with list it…
derekblank Aug 19, 2022
f41577e
Mobile - Disable FastImage on Android (#43322)
Aug 18, 2022
a439a53
[Mobile] - Fix dynamic React Native version (#43058)
Aug 8, 2022
94b8447
[RNMobile] Use default placeholder text color for native List Item (#…
derekblank Aug 25, 2022
8599e8c
Mobile - Update CHANGELOG
Aug 25, 2022
10fef38
Release script: Update react-native-editor version to 1.82.0
SiobhyB Sep 1, 2022
4e2512c
Release script: Update with changes from 'npm run core preios'
SiobhyB Sep 1, 2022
60199dc
[RNMobile] Set tintColor for ActionSheetIOS (#42996)
SiobhyB Aug 8, 2022
7fe980b
Update picker's .scss to follow BEM convention (#43036)
SiobhyB Aug 22, 2022
5157b3d
Update CHANGELOG with 1.82.0 changes
SiobhyB Sep 1, 2022
570fd2d
Release script: Update react-native-editor version to 1.82.1
SiobhyB Sep 6, 2022
059e5c1
Release script: Update with changes from 'npm run core preios'
SiobhyB Sep 6, 2022
59dd5de
Mobile - List V2 - Prevent error when list is empty (#43861)
Sep 5, 2022
f761037
[Mobile] List V2 - Fixes split issues (#43949)
Sep 7, 2022
0ef2c30
Update CHANGELOG to include 1.82.1 changes
SiobhyB Sep 8, 2022
b32d772
Merge branch into trunk
SiobhyB Sep 8, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ function RichTextWrapper(
disableSuggestions,
disableAutocorrection,
containerWidth,
onEnter: onCustomEnter,
...props
},
forwardedRef
Expand Down Expand Up @@ -344,6 +345,10 @@ function RichTextWrapper(
}
}

if ( onCustomEnter ) {
onCustomEnter();
}

if ( multiline ) {
if ( shiftKey ) {
if ( ! disableLineBreaks ) {
Expand Down
29 changes: 23 additions & 6 deletions packages/block-library/src/list-item/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ import {
import { __ } from '@wordpress/i18n';
import { usePreferredColorSchemeStyle } from '@wordpress/compose';
import { useSelect } from '@wordpress/data';
import { useState, useCallback } from '@wordpress/element';
import { useState, useCallback, useRef } from '@wordpress/element';

/**
* Internal dependencies
*/
import { useSplit, useMerge } from './hooks';
import { useSplit, useMerge, useEnter } from './hooks';
import { convertToListItems } from './utils';
import { IndentUI } from './edit.js';
import styles from './style.scss';
Expand Down Expand Up @@ -116,8 +116,26 @@ export default function ListItemEdit( {
} ),
};

const preventDefault = useRef( false );
const { onEnter } = useEnter( { content, clientId }, preventDefault );
const onSplit = useSplit( clientId );
const onMerge = useMerge( clientId );
const onSplitList = useCallback(
( value ) => {
if ( ! preventDefault.current ) {
return onSplit( value );
}
},
[ clientId, onSplit ]
);
const onReplaceList = useCallback(
( blocks, ...args ) => {
if ( ! preventDefault.current ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Why is it different from web?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @ellatrix. It looks like this was introduced in #43949. That may have additional details or be a good location for discussion. Personally, I am not familiar with the details currently. cc/ @geriux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Why is it different from web?

We have a different logic when handling "Enter" events on native for RichText components, I remember we had to diverge with our own useEnter hook to allow splitting Lists in the middle. I can check the code further to provide more information since we introduced this a little over a year ago.

Is there something that's affecting this code @ellatrix or is it just have more context on this different behavior? Let us know if you want more information about it. Thanks!

onReplace( convertToListItems( blocks ), ...args );
}
},
[ clientId, onReplace, convertToListItems ]
);
const onLayout = useCallback( ( { nativeEvent } ) => {
setContentWidth( ( prevState ) => {
const { width } = nativeEvent.layout;
Expand Down Expand Up @@ -158,11 +176,10 @@ export default function ListItemEdit( {
placeholderTextColor={
defaultPlaceholderTextColorWithOpacity
}
onSplit={ onSplit }
onSplit={ onSplitList }
onMerge={ onMerge }
onReplace={ ( blocks, ...args ) => {
onReplace( convertToListItems( blocks ), ...args );
} }
onReplace={ onReplaceList }
onEnter={ onEnter }
style={ styleWithPlaceholderOpacity }
deleteEnter={ true }
containerWidth={ contentWidth }
Expand Down
77 changes: 77 additions & 0 deletions packages/block-library/src/list-item/hooks/use-enter.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/**
* WordPress dependencies
*/
import {
createBlock,
getDefaultBlockName,
cloneBlock,
} from '@wordpress/blocks';
import { useRef } from '@wordpress/element';
import { useSelect, useDispatch } from '@wordpress/data';
import { store as blockEditorStore } from '@wordpress/block-editor';

/**
* Internal dependencies
*/
import useOutdentListItem from './use-outdent-list-item';

export default function useEnter( props, preventDefault ) {
const { replaceBlocks, selectionChange } = useDispatch( blockEditorStore );
const { getBlock, getBlockRootClientId, getBlockIndex } =
useSelect( blockEditorStore );
const propsRef = useRef( props );
propsRef.current = props;
const [ canOutdent, outdentListItem ] = useOutdentListItem(
propsRef.current.clientId
);

return {
onEnter() {
const { content, clientId } = propsRef.current;
if ( content.length ) {
return;
}
preventDefault.current = true;
if ( canOutdent ) {
outdentListItem();
return;
}
// Here we are in top level list so we need to split.
const topParentListBlock = getBlock(
getBlockRootClientId( clientId )
);
const blockIndex = getBlockIndex( clientId );
const head = cloneBlock( {
...topParentListBlock,
innerBlocks: topParentListBlock.innerBlocks.slice(
0,
blockIndex
),
} );
const middle = createBlock( getDefaultBlockName() );
// Last list item might contain a `list` block innerBlock
// In that case append remaining innerBlocks blocks.
const after = [
...( topParentListBlock.innerBlocks[ blockIndex ]
.innerBlocks[ 0 ]?.innerBlocks || [] ),
...topParentListBlock.innerBlocks.slice( blockIndex + 1 ),
];
const tail = after.length
? [
cloneBlock( {
...topParentListBlock,
innerBlocks: after,
} ),
]
: [];
replaceBlocks(
topParentListBlock.clientId,
[ head, middle, ...tail ],
1
);
// We manually change the selection here because we are replacing
// a different block than the selected one.
selectionChange( middle.clientId );
},
};
}
2 changes: 1 addition & 1 deletion packages/react-native-aztec/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-aztec",
"version": "1.82.0",
"version": "1.82.1",
"description": "Aztec view for react-native.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-bridge/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-bridge",
"version": "1.82.0",
"version": "1.82.1",
"description": "Native bridge library used to integrate the block editor into a native App.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ For each user feature we should also add a importance categorization label to i

## Unreleased

## 1.82.1
- [**] List block v2: Fix issues splitting or merging paragraphs into the block [#43949]

## 1.82.0
- [*] [iOS] Explicitly set tint color for action sheets to always be blue [#43759]

Expand Down
8 changes: 4 additions & 4 deletions packages/react-native-editor/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ PODS:
- ReactCommon/turbomodule/core (= 0.66.2)
- fmt (6.2.1)
- glog (0.3.5)
- Gutenberg (1.82.0):
- Gutenberg (1.82.1):
- React-Core (= 0.66.2)
- React-CoreModules (= 0.66.2)
- React-RCTImage (= 0.66.2)
Expand Down Expand Up @@ -350,7 +350,7 @@ PODS:
- React-Core
- RNSVG (9.13.6):
- React-Core
- RNTAztecView (1.82.0):
- RNTAztecView (1.82.1):
- React-Core
- WordPress-Aztec-iOS (~> 1.19.8)
- SDWebImage (5.11.1):
Expand Down Expand Up @@ -528,7 +528,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 18438b1c04ce502ed681cd19db3f4508964c082a
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: 5337263514dd6f09803962437687240c5dc39aa4
Gutenberg: ecbe9a4c5cb35fcabf1f7b524f56e4242fb9ee9f
Gutenberg: 4c406229dfc941c04dc1923ef661bc42cdf48c42
libwebp: 98a37e597e40bfdb4c911fc98f2c53d0b12d05fc
RCT-Folly: a21c126816d8025b547704b777a2ba552f3d9fa9
RCTRequired: 5e9e85f48da8dd447f5834ce14c6799ea8c7f41a
Expand Down Expand Up @@ -569,7 +569,7 @@ SPEC CHECKSUMS:
RNReanimated: b413cc7aa3e2a740d9804cda3a9396a68f9eea7f
RNScreens: 953633729a42e23ad0c93574d676b361e3335e8b
RNSVG: 36a7359c428dcb7c6bce1cc546fbfebe069809b0
RNTAztecView: d147b75ad3ec3fd43bce60c7c4d96e93b7294090
RNTAztecView: 8cb0bd37845a25eab416611e92d5adaf5a4931ac
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImageWebPCoder: 908b83b6adda48effe7667cd2b7f78c897e5111d
WordPress-Aztec-iOS: 7d11d598f14c82c727c08b56bd35fbeb7dafb504
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-editor",
"version": "1.82.0",
"version": "1.82.1",
"description": "Mobile WordPress gutenberg editor.",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down