Skip to content

UnitControl: Use hideHTMLArrows prop to hide spin buttons #43985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 4 commits into from
Sep 14, 2022
Merged

UnitControl: Use hideHTMLArrows prop to hide spin buttons #43985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c770c83
UnitControl: Use `hideHTMLArrows` prop to hide spin buttons
mirka Sep 7, 2022
0a6cb9a
Add changelog
mirka Sep 13, 2022
fa3a151
Always hide step buttons in UnitControl
mirka Sep 13, 2022
60b8580
Update test to avoid unnecessary snapshot
mirka Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test to avoid unnecessary snapshot
  • Loading branch information
@mirka
mirka committed Sep 14, 2022
commit 60b85800d3b599218ca338b2348b4c7394af0f92
31 changes: 0 additions & 31 deletions packages/components/src/unit-control/test/__snapshots__/index.tsx.snap
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions packages/components/src/unit-control/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,12 @@ describe( 'UnitControl', () => {
<UnitControl className="hello" />
);

expect( withoutClassName.firstChild ).toMatchDiffSnapshot(
withClassName.firstChild
);
expect(
withoutClassName.querySelector( '.components-unit-control' )
).not.toHaveClass( 'hello' );
expect(
withClassName.querySelector( '.components-unit-control' )
).toHaveClass( 'hello' );
} );

it( 'should not render select, if units are disabled', () => {
Expand Down