Skip to content

List: make allowedBlocks setting a constant #44011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellatrix wants to merge 1 commit into from
Closed

List: make allowedBlocks setting a constant #44011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
List: make allowedBlocks setting a constant
  • Loading branch information
@ellatrix
ellatrix committed Sep 9, 2022
commit 6ca7e4abb3e87a8ddd555735b2a6057fd1ff67eb
4 changes: 3 additions & 1 deletion packages/block-library/src/list-item/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import {
} from './hooks';
import { convertToListItems } from './utils';

const ALLOWED_BLOCKS = [ 'core/list' ];

export function IndentUI( { clientId } ) {
const [ canIndent, indentListItem ] = useIndentListItem( clientId );
const [ canOutdent, outdentListItem ] = useOutdentListItem( clientId );
Expand Down Expand Up @@ -64,7 +66,7 @@ export default function ListItemEdit( {
const { placeholder, content } = attributes;
const blockProps = useBlockProps( { ref: useCopy( clientId ) } );
const innerBlocksProps = useInnerBlocksProps( blockProps, {
allowedBlocks: [ 'core/list' ],
allowedBlocks: ALLOWED_BLOCKS,
} );
const useEnterRef = useEnter( { content, clientId } );
const useSpaceRef = useSpace( clientId );
Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/list/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import TagName from './tag-name';

const TEMPLATE = [ [ 'core/list-item' ] ];
const NATIVE_MARGIN_SPACING = 8;
const ALLOWED_BLOCKS = [ 'core/list-item' ];

/**
* At the moment, deprecations don't handle create blocks from attributes
Expand Down Expand Up @@ -128,7 +129,7 @@ export default function Edit( { attributes, setAttributes, clientId, style } ) {
...( Platform.isNative && { style } ),
} );
const innerBlocksProps = useInnerBlocksProps( blockProps, {
allowedBlocks: [ 'core/list-item' ],
allowedBlocks: ALLOWED_BLOCKS,
Copy link
Member

@ZebulanStanphill ZebulanStanphill Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole object passed as the second arg of this useInnerBlocksProps() call could be a constant, couldn't it?

Copy link
Member Author

@ellatrix ellatrix Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be, but I think we shallow compare it anyway, so there would be no point.

template: TEMPLATE,
templateLock: false,
templateInsertUpdatesSelection: true,
Expand Down