Skip to content

Comments Pagination: Avoid creating a new allowedBlocks array on every render #44021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Sep 9, 2022
Merged

Comments Pagination: Avoid creating a new allowedBlocks array on every render #44021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Comments Pagination: Avoid creating a new allowedBlocks array on ever… 
…y render
  • Loading branch information
@Mamaduka
Mamaduka committed Sep 9, 2022
commit 032cf740c9d68b78d63a379f552f448e468494ab
11 changes: 6 additions & 5 deletions packages/block-library/src/comments-pagination/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ const TEMPLATE = [
[ 'core/comments-pagination-numbers' ],
[ 'core/comments-pagination-next' ],
];
const ALLOWED_BLOCKS = [
'core/comments-pagination-previous',
'core/comments-pagination-numbers',
'core/comments-pagination-next',
];

const getDefaultBlockLayout = ( blockTypeOrName ) => {
const layoutBlockSupportConfig = getBlockSupport(
Expand Down Expand Up @@ -58,11 +63,7 @@ export default function QueryPaginationEdit( {
const blockProps = useBlockProps();
const innerBlocksProps = useInnerBlocksProps( blockProps, {
template: TEMPLATE,
allowedBlocks: [
'core/comments-pagination-previous',
'core/comments-pagination-numbers',
'core/comments-pagination-next',
],
allowedBlocks: ALLOWED_BLOCKS,
__experimentalLayout: usedLayout,
} );

Expand Down