Skip to content

[Block Library - Query Loop]: Suggest active variation patterns #44197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 4 commits into from
Sep 16, 2022
Merged

[Block Library - Query Loop]: Suggest active variation patterns #44197

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea992e9
[Block Library - Query Loop]: Suggest active variation patterns
ntsekouras Sep 15, 2022
6e0c5d2
optimization when no active variation exists
ntsekouras Sep 16, 2022
0324dc1
minor tweak
ntsekouras Sep 16, 2022
ee325a5
comment clarification
ntsekouras Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
comment clarification
  • Loading branch information
@ntsekouras
ntsekouras committed Sep 16, 2022
commit ee325a5e9b26cbb1ae03440d70f556777a9b28ef
8 changes: 5 additions & 3 deletions packages/block-library/src/query/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,12 @@ export const getTransformedBlocksFromPattern = (
/**
* Helper hook that determines if there is an active variation of the block
* and if there are available specific patterns for this variation.
* If there are, they are going to be suggested to the user in setup and
* replace flow.
* If there are, these patterns are going to be the only ones suggested to
* the user in setup and replace flow, without including the default ones
* for Query Loop.
*
* If there are no patterns, the default ones for Query Loop are going to be suggested.
* If there are no such patterns, the default ones for Query Loop are going
* to be suggested.
*
* @param {string} clientId The block's client ID.
* @param {Object} attributes The block's attributes.
Expand Down