Components refactor Mobile to ignore exhuastive-deps
#44207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Type] Code Quality
44 tasks
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
Contributor
Good point @chad1008, I advocate the idea of deferring to the native team to handle the review of the dependencies, especially, since some of them might require further exploration, thanks! We don't have too much bandwidth currently for tackling this in the short term but I hope we could do it in the future. UPDATE: As a follow-up task, I created this issue to continue the refactor of the native files. |
chad1008
deleted the
refactor/mobile-components-ignore-exhaustive-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the Mobile components to ignore the
exhaustive-depseslint rule.Why?
Because the Components squad generally lacks the React Native expertise and tools/environments to effectively refactor these components, we'll defer to the native team to handle when they're ready.
How?
Added inline ignore comments to all
exhaustive-depswarnings in theMobilecomponent directoryTesting Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/mobile